PHP warning fix for the autoLoad() function #12684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small alteration should fix this situation: https://forum.phalconphp.com/discussion/10339/strange-warning-probably-from-zephirfaststrreplace-or-something- If you have two classes: My\Class\Foo\Bar and My\Class\Foo When initializing Foo() the autoLoad will come to this line "let fileName = substr(className, strlen(nsPrefix . ns));" at the moment where className = "My\Class\Foo" and nsPrefix = "My\Class\Foo\Bar" At this point (could be a zephir bug) fileName is something that will make "let fileName = str_replace(ns, ds, fileName);" throw the following warning (Invalid arguments supplied for str_replace()). Either substr is returning something other than an empy string or str_replace is not allowing an empy string either way testing if fileName has any value before "let fileName = str_replace(ns, ds, fileName);" should mitigate this warning.
|
We don't accept PR to master. Please send it to 3.1.x. Also provide some test which was causing this warning to be produced so we know this is fixed as well update changelog. |
3 tasks
|
Fixed in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
This small alteration should fix this situation: https://forum.phalconphp.com/discussion/10339/strange-warning-probably-from-zephirfaststrreplace-or-something-
If you have two classes:
My\Class\Foo\Barand
My\Class\FooWhen initializing
Foo()the autoLoad will come to this lineat the moment where
className = "My\Class\Foo"andnsPrefix = "My\Class\Foo\Bar"At this point (could be a Zephir bug)
fileNameis something that will makethrow the following warning (Invalid arguments supplied for
str_replace()). Eithersubstris returning something other than an empy string orstr_replaceis not allowing an empy string either way testing iffileNamehas any value beforeshould mitigate this warning.
Thanks